sureshanaparti commented on a change in pull request #5750:
URL: https://github.com/apache/cloudstack/pull/5750#discussion_r768318332
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java
##########
@@ -194,8 +197,9 @@ public MigrationResponse migrateData(Long srcDataStoreId,
List<Long> destDatasto
destDatastoreId = orderedDS.get(1);
}
- if (chosenFileForMigration.getSize() >
storageCapacities.get(destDatastoreId).first()) {
- s_logger.debug("file: " + chosenFileForMigration.getId() + "
too large to be migrated to " + destDatastoreId);
+ if (chosenFileForMigration.getPhysicalSize() >
storageCapacities.get(destDatastoreId).first()) {
+ s_logger.debug(String.format("%s: %s too large to be migrated
to %s", getObjectType(chosenFileForMigration),
chosenFileForMigration.getUuid(), destDatastoreId));
+ skipped += 1;
continue;
Review comment:
Does the files migrated have any relation (eg. template info and
template file)? Is it ok to migrate other files, if one large file is skipped
in a group of related files? or Is it better to check with the cumulative size
of all the related files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
