weizhouapache commented on pull request #5782:
URL: https://github.com/apache/cloudstack/pull/5782#issuecomment-995963065
> > @Pearl1594 @sureshanaparti @DaanHoogland
> > do we need to fix the similar issue in following file ?
> > ```
> >
engine/schema/src/main/java/org/apache/cloudstack/acl/dao/ProjectRoleDaoImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
sc.setParameters("name", "%" + name + "%");
> >
server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java:
sc.setParameters("name", "%" + keyword + "%");
> > server/src/main/java/com/cloud/server/ManagementServerImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/server/ManagementServerImpl.java:
sc.setParameters("name", "%" + name + "%");
> > server/src/main/java/com/cloud/server/ManagementServerImpl.java:
sc.setParameters("name", "%" + podName + "%");
> >
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
sc.setParameters("name", "%" + name + "%");
> >
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
sc.setParameters("name", "%" + keyword + "%");
> > ```
>
> Agree, if name param in the API has to exactly match with the name in the
respective resource. Please note, this may fail any of the scripts written
considering the name param as keyword (as it changes the API response behavior).
@sureshanaparti yes, it will break backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
