GabrielBrascher commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1003689692
@DaanHoogland I think that there are no smoke tests covering it indeed. The code looks good but I have no VMware staging environment so I would not be able to test it. I am trusting in the author's testing it. To mitigate issues or future changes in the code that could affect this behavior I`ve suggested extracting a few parts of the added method and creating unit tests to cover a few of the String parsing logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
