nvazquez commented on a change in pull request #5750:
URL: https://github.com/apache/cloudstack/pull/5750#discussion_r777467778



##########
File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java
##########
@@ -194,8 +197,9 @@ public MigrationResponse migrateData(Long srcDataStoreId, 
List<Long> destDatasto
                 destDatastoreId = orderedDS.get(1);
             }
 
-            if (chosenFileForMigration.getSize() > 
storageCapacities.get(destDatastoreId).first()) {
-                s_logger.debug("file: " + chosenFileForMigration.getId() + " 
too large to be migrated to " + destDatastoreId);
+            if (chosenFileForMigration.getPhysicalSize() > 
storageCapacities.get(destDatastoreId).first()) {
+                s_logger.debug(String.format("%s: %s too large to be migrated 
to %s", getObjectType(chosenFileForMigration), 
chosenFileForMigration.getUuid(), destDatastoreId));
+                skipped += 1;
                 continue;

Review comment:
       Afaik multi-disk templates wouldn't necessarily need to go to the same 
store




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to