rohityadavcloud commented on a change in pull request #5828:
URL: https://github.com/apache/cloudstack/pull/5828#discussion_r780625438
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -16,6 +16,7 @@
// under the License.
package com.cloud.vm;
+import static
com.cloud.configuration.ConfigurationManagerImpl.VM_USERDATA_MAX_LENGTH;
Review comment:
@shwstppr generally bad practice to import/depend on an `impl`; instead
refactor the static field from an interface/service/manager than an impl class.
If this value is determined/depends on a configkey, maybe use a getter.
Otherwise LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
