sureshanaparti commented on a change in pull request #5544:
URL: https://github.com/apache/cloudstack/pull/5544#discussion_r788740152
##########
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -1332,33 +1327,12 @@ private void updateSnapshotPayload(long storagePoolId,
CreateSnapshotPayload pay
}
}
- private DataStoreRole getDataStoreRole(Snapshot snapshot,
SnapshotDataStoreDao snapshotStoreDao, DataStoreManager dataStoreMgr) {
- SnapshotDataStoreVO snapshotStore =
snapshotStoreDao.findBySnapshot(snapshot.getId(), DataStoreRole.Primary);
-
- if (snapshotStore == null) {
- return DataStoreRole.Image;
- }
-
- long storagePoolId = snapshotStore.getDataStoreId();
- DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId,
DataStoreRole.Primary);
-
- Map<String, String> mapCapabilities =
dataStore.getDriver().getCapabilities();
-
- if (mapCapabilities != null) {
- String value =
mapCapabilities.get(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString());
- Boolean supportsStorageSystemSnapshots = new Boolean(value);
-
Review comment:
@slavkap I agree, it doesn't break for the pools with this last
capability flag set. Last code returns `DataStoreRole.Primary` when the
snapshot exists in the primary storage and the storage system snapshot
capability flag is set for the pool. No issues with 'PowerFlex', as the flag is
set in _ScaleIOPrimaryDataStoreDriver_. It seems this is not set for 'RBD', Can
you check if there is any issue with it and other pools using
_CloudStackPrimaryDataStoreDriverImpl_. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
