shwstppr commented on pull request #5854:
URL: https://github.com/apache/cloudstack/pull/5854#issuecomment-1018390605


   @DaanHoogland @weizhouapache @rohityadavcloud @sureshanaparti cc 
@borisstoyanov As I've mentioned earlier my approach can break UI in some 
scenarios. Below is an example:
   - Login with redirection `?redirect=%2Faction%2FdeployVirtualMachine`
   - Before 2nd listApis call is completed (Discovering features notification 
still showing), click on create network. This will result in empty form
   ![Screenshot from 2022-01-21 
15-55-26](https://user-images.githubusercontent.com/153340/150511736-c2db2f02-e9aa-4001-954c-645bb23e73e9.png)
   
   I've already added a change to hide view action buttons till feature 
discovery is complete but there could be still many place in UI which may show 
similar error when login is done with redirection (or the listApis call with 
complete response is still running).
   
   I've also tried role based caching of API lists in the backend but that 
hardly makes any difference in UI login.
   ![Screenshot from 2022-01-21 
15-49-47](https://user-images.githubusercontent.com/153340/150512169-09ec58fa-cdda-418f-9b4e-80f7e5a0ea69.png)
   
   Therefore, at this point I'm of the opinion of closing this PR (or creating 
a new one with only APIChecker improvements) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to