DaanHoogland commented on a change in pull request #5886:
URL: https://github.com/apache/cloudstack/pull/5886#discussion_r792447539
##########
File path: server/src/main/java/com/cloud/resource/DiscovererBase.java
##########
@@ -51,6 +54,16 @@
protected ResourceManager _resourceMgr;
@Inject
protected DataCenterDao _dcDao;
+ @Inject
+ private ImageStoreDao imageStoreDao;
+
+ protected void setSecondaryStorageNfsVersionToParams(Long zoneId,
Map<String, Object> params) {
+ ImageStoreVO imageStoreInZone =
imageStoreDao.findOneByZoneAndProtocol(zoneId, "nfs");
Review comment:
@nvazquez @sureshanaparti I do not see a problem here. Unless I am
looking at the code in isolation too much and should be looking at a bigger
picture, what happens here:
```
a store is picked
if a store is found
- the nfs version for that store is retrieved and used
if not
- the default nfs version is used
```
what could go wrong here is only that the operator has not set the right nfs
versions to the system/stores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
