DaanHoogland commented on a change in pull request #5879:
URL: https://github.com/apache/cloudstack/pull/5879#discussion_r792479516
##########
File path:
api/src/test/java/org/apache/cloudstack/api/command/admin/account/CreateAccountCmdTest.java
##########
@@ -73,7 +73,7 @@ public void testExecuteWithNotBlankPassword() {
} catch (ServerApiException e) {
Assert.assertTrue("Received exception as the mock accountService
createUserAccount returns null user", true);
}
- Mockito.verify(accountService,
Mockito.times(1)).createUserAccount(null, "Test", null, null, null, null, null,
accountType, roleId, domainId, null, null, null, null);
+ Mockito.verify(accountService,
Mockito.times(1)).createUserAccount(createAccountCmd);
Review comment:
It actually doesn't matter for this flimsy test case. We are only
verifying that the command is passed to the service, not the handling of it in
the service. The service is a mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
