DaanHoogland commented on a change in pull request #5866:
URL: https://github.com/apache/cloudstack/pull/5866#discussion_r792624130
##########
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##########
@@ -397,6 +363,59 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
return new Pair<List<? extends Usage>, Integer>(usageRecords.first(),
usageRecords.second());
}
+ private Long getDomainScopeForQuery(ListUsageRecordsCmd cmd, Long
accountId, Long domainId, Account caller, boolean isDomainAdmin) {
+ if (isDomainAdmin) {
Review comment:
@GutoVeronezi I like this better
the choice is
- two indentation levels and one return/exit point vs
- one indentation and two returns/exit points
I rather have the first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
