GutoVeronezi commented on a change in pull request #5588:
URL: https://github.com/apache/cloudstack/pull/5588#discussion_r792721037
##########
File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java
##########
@@ -53,19 +62,44 @@
void registerDispatcher(Dispatcher dispatcher);
+ /**
+ * register a listener for incoming status changes of ManagementServers
+ *
+ * @param administrator the object administrating statusses
+ */
+ void registerStatusAdministrator(StatusAdministrator administrator);
+
ManagementServerHost getPeer(String peerName);
+ /**
+ *
+ * @return {code}Long.toString({code}{@see
getManagementNodeId()}{code}){code}
+ */
String getSelfPeerName();
long getManagementNodeId();
+ /**
+ * determined by the time
+ * @return start time as {code}System.currentTimeMillis(){code}
+ */
long getCurrentRunId();
- public long getManagementRunId(long msId);
+ /**
+ * the other guy's is derived from start time as stored in the db
+ */
+ long getManagementRunId(long msId);
- public interface Dispatcher {
+ interface Dispatcher {
String getName();
String dispatch(ClusterServicePdu pdu);
}
+
+ /**
+ * what the client of {@see registerStatusAdministrator()} should implement
+ */
+ interface StatusAdministrator {
+ String newStatus(ClusterServicePdu pdu);
+ }
Review comment:
Just some improvements in writing and punctuation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
