GutoVeronezi commented on a change in pull request #5859:
URL: https://github.com/apache/cloudstack/pull/5859#discussion_r792673209
##########
File path:
plugins/affinity-group-processors/explicit-dedication/src/main/java/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java
##########
@@ -305,6 +305,9 @@ private ExcludeList
updateAvoidList(List<DedicatedResourceVO> dedicatedResources
for (HostPodVO pod : podList) {
DedicatedResourceVO dPod =
_dedicatedDao.findByPodId(pod.getId());
if (dPod != null && !dedicatedResources.contains(dPod)) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("Avoiding POD %s[%s]
because it is dedicated.", pod.getName(), pod.getUuid()));
Review comment:
```suggestion
s_logger.debug(String.format("Avoiding POD %s
[%s] because it is dedicated.", pod.getName(), pod.getUuid()));
```
##########
File path:
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -754,9 +754,17 @@ public void
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, DataC
//Only when the type is instance VM and not explicitly dedicated.
if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
//add explicitly dedicated resources in avoidList
-
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug("adding pods to avoid lists for non-exlicit vm
deployment: " + allPodsInDc);
Review comment:
```suggestion
s_logger.debug("Adding pods to avoid lists for non-explicit
VM deployment: " + allPodsInDc);
```
##########
File path:
plugins/affinity-group-processors/explicit-dedication/src/main/java/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java
##########
@@ -343,6 +346,9 @@ private ExcludeList
updateAvoidList(List<DedicatedResourceVO> dedicatedResources
for (HostPodVO pod : pods) {
if (podsInIncludeList != null &&
!podsInIncludeList.contains(pod.getId())) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("Avoiding POD %s[%s], as it
is not in include list.", pod.getName(), pod.getUuid()));
Review comment:
```suggestion
s_logger.debug(String.format("Avoiding POD %s [%s], as
it is not in include list.", pod.getName(), pod.getUuid()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
