utchoang commented on a change in pull request #5904:
URL: https://github.com/apache/cloudstack/pull/5904#discussion_r793374779
##########
File path: ui/src/views/network/CreateIsolatedNetworkForm.vue
##########
@@ -344,11 +344,13 @@ export default {
var params = {
zoneid: this.selectedZone.id,
guestiptype: 'Isolated',
- supportedServices: 'SourceNat',
state: 'Enabled'
}
- if (isAdminOrDomainAdmin() && this.selectedDomain.id !== '-1') { //
domain is visible only for admins
- params.domainid = this.selectedDomain.id
+ if (isAdminOrDomainAdmin()) {
+ params.supportedServices = 'SourceNat'
Review comment:
Does it mean for normal users and admin can only add isolated networks
with source nat service?
##########
File path: ui/src/views/network/CreateIsolatedNetworkForm.vue
##########
@@ -344,11 +344,13 @@ export default {
var params = {
zoneid: this.selectedZone.id,
guestiptype: 'Isolated',
- supportedServices: 'SourceNat',
state: 'Enabled'
}
- if (isAdminOrDomainAdmin() && this.selectedDomain.id !== '-1') { //
domain is visible only for admins
- params.domainid = this.selectedDomain.id
+ if (isAdminOrDomainAdmin()) {
+ params.supportedServices = 'SourceNat'
Review comment:
Does it mean for normal users and admin can add isolated networks with
source nat service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
