SadiJr commented on a change in pull request #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r794785575
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -304,7 +304,7 @@
static Boolean rulesContinueOnErrFlag = true;
- private static final ConfigKey<Boolean>
SystemVmPublicIpReservationModeStrictness = new ConfigKey<Boolean>("Advanced",
+ public static ConfigKey<Boolean> SystemVmPublicIpReservationModeStrictness
= new ConfigKey<Boolean>("Advanced",
Review comment:
@DaanHoogland thanks for the suggestion.
I made these changes so that I could perform the unit tests. Unfortunately
it was the only way I could test different configuration values. If you have
any suggestions on this, I would be very grateful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
