DaanHoogland commented on a change in pull request #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r795444770
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -304,7 +304,7 @@
static Boolean rulesContinueOnErrFlag = true;
- private static final ConfigKey<Boolean>
SystemVmPublicIpReservationModeStrictness = new ConfigKey<Boolean>("Advanced",
+ public static ConfigKey<Boolean> SystemVmPublicIpReservationModeStrictness
= new ConfigKey<Boolean>("Advanced",
Review comment:
I don't undestand why you would have to do that. The `IpAddressManager`
you added for your test is already a mock and you can let it return anything
you want. if need be you can add a `IsSVMReservationStrict()` method for
convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
