harikrishna-patnala opened a new pull request #5912: URL: https://github.com/apache/cloudstack/pull/5912
### Description This PR fixes #5716 where isolated network VR failed to deploy when Vmxnet3 adapter type is used and when router.extra.public.nics is not 0. This is because of the extra nics that are reserved in the VR based on the global setting router.extra.public.nics. To address the issue we have now implemented nic hot plugging for isolated networks because systemvm templates had open-vm-tools installed and support hot plugging which is what is already used in the case of VPC VR. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Steps to reproduce: 1. Set the global setting vmware.systemvm.nic.device.type to Vmxnet3 and router.extra.public.nics to some value (not 0) 2. Create an isolated network and VM in it. 3. VR will stuck in starting state After the fix, following are the test cases that are performed 1. Set the global setting vmware.systemvm.nic.device.type to Vmxnet3. router.extra.public.nics is not used in VMware anymore. 2. Create an isolated network N1 and VM in it 3. Add a new IP range with different vlan under "Physical Network Guest Public". 4. Aquire an IP from the above range in the network N1 5. Enable staticnat on that IP 6. Observed VR interfaces a new interface is created dynamically Followed the same steps with vmware.systemvm.nic.device.type value E1000 and VR came up and subsequent operations of acquiring IP, enabling static NAT worked fine. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
