shwstppr commented on pull request #5850: URL: https://github.com/apache/cloudstack/pull/5850#issuecomment-1028628183
> @shwstppr I tested this pr just now. I noticed your comment ([#5711 (comment)](https://github.com/apache/cloudstack/issues/5711#issuecomment-1009803647)), however I think users should be able to create vpn user even if there is no remote access vpn enabled. > > the issues I found are (1) cannot create vpn user for other account which do not have any isolated network. (2) exception when create vpn user for other account which has isolated network but in 'Allocated' state. but vpn user is added in DB. (2) exception when remove vpn user for other account which has isolated network but in 'Allocated' state. but vpn user is removed in DB. @weizhouapache For adding user for an account without VPN access, currently code searches for available VPNs. Should we simply skip the apply part and just create the user in this case? 1. Should we allow creating user in this case? 2. Again, should we allow creating user in this case or should we show a proper error message? 3. User should get deleted in this case without error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
