nvazquez commented on a change in pull request #5910:
URL: https://github.com/apache/cloudstack/pull/5910#discussion_r800058186
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1805,6 +1805,14 @@ protected void ensureDiskControllers(VirtualMachineMO
vmMo, Pair<String, String>
int requiredNumScsiControllers =
VmwareHelper.MAX_SCSI_CONTROLLER_COUNT - scsiControllerInfo.first();
int availableBusNum = scsiControllerInfo.second() + 1; // method
returned current max. bus number
+ if (DiskControllerType.getType(scsiDiskController) !=
scsiControllerInfo.third()) {
Review comment:
In most of the cases yes - the only case in which `third()` is the type
of the data disk controller is when the root disk controller is IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
