SadiJr commented on pull request #5457: URL: https://github.com/apache/cloudstack/pull/5457#issuecomment-1032667868
@DaanHoogland @rohityadavcloud I was reviewing my PRs, and realized that I ended up not being clear in my explanation of my changes. Currently, the integration with Veeam, does not allow users to remove specific backups. This can be seen in the org.apache.cloudstack.backup.VeeamBackupProvider.deleteBackup(Backup) method, where, when attempting to remove a specific backup, the following exception is thrown: ``` Veeam B&R plugin does not allow removal of backup restore point, to delete the backup chain remove VM from the backup offering ``` However, with Veeam, this operation results in Veeam's job continuing to exist in the backend, and consequently continuing to attempt to perform backup of a VM that no longer exists because the VM was deleted without unassigning it from the backip offering. The goal of this PR is to make sure that the user who owns a VM that has a Backup Offering as well as backups is prevented from destroying the VM before the user assigns the VM from the backup offering. I agree that ideally the right thing would be to allow removing the VM and removing the job in Veeam, but keeping the backups; however, the integration does not allow this kind of operation so far. Unfortunately I didn't get to look at the Veeam documentation on this, so I can't say if this is a Veeam or ACS limitation. Finally, regarding @RodrigoDLopez suggestions, I came to the conclusion that they should be implemented, but in a separated PR, in order to separate the contexts, since the current PR is only about changing the API. I will remove the draft of this PR and ask you to re-review it. Suggestions are always welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
