DaanHoogland commented on a change in pull request #5911:
URL: https://github.com/apache/cloudstack/pull/5911#discussion_r802717992
##########
File path: api/src/main/java/com/cloud/storage/GuestOS.java
##########
@@ -33,5 +33,5 @@
Date getRemoved();
- boolean isUserDefined();
+ boolean getIsUserDefined();
Review comment:
why this rename? convention on primitive boolean getters is
`is`+`<property-name>`.
##########
File path: engine/schema/src/main/java/com/cloud/storage/GuestOSVO.java
##########
@@ -113,7 +113,7 @@ public Date getRemoved() {
}
@Override
- public boolean isUserDefined() {
+ public boolean getIsUserDefined() {
Review comment:
not a good rename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
