sureshanaparti commented on a change in pull request #5910:
URL: https://github.com/apache/cloudstack/pull/5910#discussion_r802740196
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -2293,6 +2293,43 @@ public int getPvScsiDeviceControllerKey() throws
Exception {
throw new Exception("VMware Paravirtual SCSI Controller Not Found");
}
+ protected VirtualSCSIController getScsiController(DiskControllerType type)
{
+ switch (type) {
+ case pvscsi:
+ return new ParaVirtualSCSIController();
+ case lsilogic:
+ return new VirtualLsiLogicController();
+ case lsisas1068:
+ return new VirtualLsiLogicSASController();
+ case buslogic:
+ return new VirtualBusLogicController();
+ default:
+ return new VirtualLsiLogicController();
+ }
Review comment:
@nvazquez check and address if this is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
