weizhouapache commented on a change in pull request #5970:
URL: https://github.com/apache/cloudstack/pull/5970#discussion_r804543465
##########
File path: ui/src/config/section/network.js
##########
@@ -38,7 +38,7 @@ export default {
return fields
},
details: () => {
- var fields = ['name', 'id', 'description', 'type', 'traffictype',
'vpcid', 'vlan', 'broadcasturi', 'cidr', 'ip6cidr', 'netmask', 'gateway',
'aclname', 'ispersistent', 'restartrequired', 'reservediprange',
'redundantrouter', 'networkdomain', 'zonename', 'account', 'domain']
Review comment:
@Pearl1594
would it be good to highlight the egress policy or the behavior (allow/deny)
of egress rules in "Egress rules" tab ?
e.g. if egress policy is true, display a message like "The traffic
matching the following rules will be denied"
##########
File path: ui/src/views/offering/AddNetworkOffering.vue
##########
@@ -342,7 +342,7 @@
<tooltip-label slot="label" :title="$t('label.egressdefaultpolicy')"
:tooltip="apiParams.egressdefaultpolicy.description"/>
<a-radio-group
v-decorator="['egressdefaultpolicy', {
- initialValue: 'allow'
+ initialValue: 'deny'
Review comment:
@Pearl1594
this change is not needed I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
