DaanHoogland commented on a change in pull request #5986:
URL: https://github.com/apache/cloudstack/pull/5986#discussion_r805633198
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -776,7 +776,7 @@ public PrimaryDataStoreInfo createPool(CreateStoragePoolCmd
cmd) throws Resource
throw new InvalidParameterValueException("Missing parameter
hypervisor. Hypervisor type is required to create zone wide primary storage.");
}
if (hypervisorType != HypervisorType.KVM && hypervisorType !=
HypervisorType.VMware && hypervisorType != HypervisorType.Hyperv &&
hypervisorType != HypervisorType.LXC
- && hypervisorType != HypervisorType.Any) {
+ && hypervisorType != HypervisorType.Any && hypervisorType
!= HypervisorType.Simulator) {
Review comment:
background, there is too much mention of simulator in production code.
If we can avoid this we should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
