harikrishna-patnala commented on a change in pull request #5990:
URL: https://github.com/apache/cloudstack/pull/5990#discussion_r807551823
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4344,11 +4356,6 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
} else {
vm.setDetail(key, customParameters.get(key));
}
-
- if
(key.equalsIgnoreCase(ApiConstants.BootType.UEFI.toString())) {
Review comment:
I think we need to add this too, if template details do not have any
data, we need to set the deploy VM param into VM details.
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4336,6 +4336,18 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
vm.setUserVmType(type);
_vmDao.persist(vm);
for (String key : customParameters.keySet()) {
+ // BIOS was explicitly passed as the boot type, so honour
it
Review comment:
what if template details has UEFI -> LEGACY and deploy VM passes UEFI ->
SECURE ? As per my understanding, we are considering template details, since we
are not deleting from vm.details if boot type is UEFI. (vn.details is loaded
with template details before this).
If precedence goes to template details this is fine, but it might be
confusing to the user if he/she provides SECURE mode during VM deploy but it is
not honoured since template has other detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
