davidjumani commented on pull request #5965: URL: https://github.com/apache/cloudstack/pull/5965#issuecomment-1048637997
> @davidjumani code looks good to me. tested ok. > > I have few questions or suggestions > > (1) for existing vms which has `SSH.PublicKey` in user_vm_details before cloudstack upgrade, would be good to add a record `SSH.KeyPairNames` in the table ? > > (2) the URL of ssh keypair page is http://localhost:5050/#/ssh/. What if there are multiple ssh keypairs with same name on the platform ? uuid looks better than ssh keypair name. > > (3) on UI, can the existing ssh keypair be checked by default when open the dialog of reset ssh keypair ? I've addressed points 1 & 3 in this PR. Point 2 might require a larger change since the uuid field was recently added to ssh keyparis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
