[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library

[GitBox]

nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1060964747


   @utchoang great work! I have been testing the PR and found out some 
visibility issues (still no functionality issues, which is great). Compared 
your PR to the current main branch and found some differences:
   
   1: Responsive seems to be broken - please check the following images while 
resizing the window:
   <img width="1678" alt="Screen Shot 2022-03-07 at 14 03 21" 
src="https://user-images.githubusercontent.com/5295080/157089838-d26008da-5639-4bd9-b19d-43790dfb7840.png";>
   <img width="826" alt="Screen Shot 2022-03-07 at 14 03 04" 
src="https://user-images.githubusercontent.com/5295080/157089854-1e836af6-6220-4acd-b3ec-ee30a7456540.png";>
   <img width="965" alt="Screen Shot 2022-03-07 at 14 02 11" 
src="https://user-images.githubusercontent.com/5295080/157089930-2e7b39f9-e061-42dd-aac0-fb6e7154eaf1.png";>
   
   2: The top-right menu buttons do not work most of the times (Profile, Help). 
Logout works after few tries
   <img width="269" alt="Screen Shot 2022-03-07 at 14 36 57" 
src="https://user-images.githubusercontent.com/5295080/157087642-63c3d333-2762-4168-a026-79f29cd4f97b.png";>
   
   3: The left menu has changed its behaviour, it now allows multiple 
collapsible menus open at the same time:
   <img width="257" alt="Screen Shot 2022-03-07 at 14 39 28" 
src="https://user-images.githubusercontent.com/5295080/157088019-b6347ada-ceb2-49bb-9910-fae04d690a2e.png";>
   
   4: Some minor CSS differences Rohit and David have mentioned
   
   Can you please address the first 3?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org