DaanHoogland commented on pull request #5938: URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1066630236
> > clgtm, seems to do what it says on the tin. One question; for vmware we query and get only one vm and reconfigure it, for Xen we get a list and iterate over it. Is this difference real or just a result of the API definitions, i.e. can there exist more then one on xen? > > sorry @DaanHoogland , can you clarify the question ? the process to pass `cmdline` to VRs is different on hypervisors. I understand that the passing is different for hypervisors but the uniqueness of the name isn't , is it? In the `VmwareResource`, `reconfigureDomainRouterAfterStart()` is executed with a name and it is retrieved and reconfigured. Only one VM is assumed and reconfigured. In the `CitrixCheckSshCommandWrapper` a `Set<>` is retrieved and a loop over the VMs is executed to reconfigure all of them. Is this difference expected or are we either overlooking something in the one case or doing extra work in the other? It would seem that if the VM is guaranteed to be unique this is true for all hypervisors equaly so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
