davidjumani commented on a change in pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#discussion_r829716845
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -374,6 +374,8 @@ def addBridge(self, brName, dev):
if self.syscfg.env.bridgeType == "openvswitch":
if cfo.getEntry("IPADDR"):
cfo.rmEntry("IPADDR", cfo.getEntry("IPADDR"))
+ elif self.syscfg.env.bridgeType == "native":
+ cfo.addEntry("BRIDGE", brName)
Review comment:
```suggestion
pass
```
At this point, we're modifying the interface not the bridge
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -374,6 +374,8 @@ def addBridge(self, brName, dev):
if self.syscfg.env.bridgeType == "openvswitch":
if cfo.getEntry("IPADDR"):
cfo.rmEntry("IPADDR", cfo.getEntry("IPADDR"))
+ elif self.syscfg.env.bridgeType == "native":
+ cfo.addEntry("BRIDGE", brName)
Review comment:
```suggestion
pass
```
At this point, we're modifying the interface not the bridge. In suse, the
bridge is mapped to the device, not the other way around
https://github.com/apache/cloudstack/blob/main/python/lib/cloudutils/serviceConfig.py#L393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
