sureshanaparti commented on a change in pull request #6132:
URL: https://github.com/apache/cloudstack/pull/6132#discussion_r830929904



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3476,8 +3476,7 @@ public UserVm 
createAdvancedSecurityGroupVirtualMachine(DataCenter zone, Service
             List<Long> securityGroupIdList, Account owner, String hostName, 
String displayName, Long diskOfferingId, Long diskSize, String group, 
HypervisorType hypervisor,
             HTTPMethod httpmethod, String userData, List<String> sshKeyPairs, 
Map<Long, IpAddresses> requestedIps, IpAddresses defaultIps, Boolean displayVm, 
String keyboard,
             List<Long> affinityGroupIdList, Map<String, String> 
customParameters, String customId, Map<String, Map<Integer, String>> 
dhcpOptionMap,
-            Map<Long, DiskOffering> dataDiskTemplateToDiskOfferingMap, 
Map<String, String> userVmOVFProperties, boolean dynamicScalingEnabled, Long 
overrideDiskOfferingId) throws InsufficientCapacityException, 
ConcurrentOperationException,
-    ResourceUnavailableException, StorageUnavailableException, 
ResourceAllocationException {
+            Map<Long, DiskOffering> dataDiskTemplateToDiskOfferingMap, 
Map<String, String> userVmOVFProperties, boolean dynamicScalingEnabled, Long 
overrideDiskOfferingId, String type) throws InsufficientCapacityException, 
ConcurrentOperationException, ResourceUnavailableException, 
StorageUnavailableException, ResourceAllocationException {

Review comment:
       ```suggestion
               Map<Long, DiskOffering> dataDiskTemplateToDiskOfferingMap, 
Map<String, String> userVmOVFProperties, boolean dynamicScalingEnabled, Long 
overrideDiskOfferingId, String vmType) throws InsufficientCapacityException, 
ConcurrentOperationException, ResourceUnavailableException, 
StorageUnavailableException, ResourceAllocationException {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to