Pearl1594 commented on a change in pull request #6146:
URL: https://github.com/apache/cloudstack/pull/6146#discussion_r831037435
##########
File path:
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
##########
@@ -639,7 +639,10 @@ private boolean deleteConfigDriveIso(final VirtualMachine
vm) throws ResourceUna
if (location == Location.SECONDARY) {
dataStore =
_dataStoreMgr.getImageStoreWithFreeCapacity(vm.getDataCenterId());
- agentId = findAgentIdForImageStore(dataStore);
+ if
(!VirtualMachineManager.VmConfigDriveOnPrimaryPool.valueIn(vm.getDataCenterId())
&&
+
!VirtualMachineManager.VmConfigDriveForceHostCacheUse.valueIn(vm.getDataCenterId())
&& dataStore != null) {
+ agentId = findAgentIdForImageStore(dataStore);
+ }
Review comment:
@sureshanaparti if case the config drive iso for the vm is on primary
store or image cache, then there is no need to search for image store agent id
. The logic is similar to
https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java#L499-L502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
