nvazquez commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r840583894
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE
table_name = 'volumes' AND table_schema='cloud' AND column_name =
'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid
VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
@DK101010 @weizhouapache thanks I was trying to do the same but forgot
the procedure was already set. I would be +1 on using this procedure, in most
cases adding the column won't be an issue, but using the idempotent addition we
can prevent manual DB intervention on failing upgrades (if somehow an upgrade
fails then if you execute the upgrade again all the columns that were added
will fail the upgrade since cannot be added again, this can be prevented using
the idempotent add)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
