rohityadavcloud commented on code in PR #6242:
URL: https://github.com/apache/cloudstack/pull/6242#discussion_r851324153


##########
api/src/main/java/com/cloud/server/ResourceTag.java:
##########
@@ -91,6 +96,53 @@ public boolean resourceMetadataSupport() {
         public boolean resourceIconSupport() {
             return resourceIconSupport;
         }
+
+        static {
+            resourceObjectTypeMap.put("uservm", UserVm);

Review Comment:
   For every ResourceObjectType, you're manually entering a map in 
resourceObjectTypeMap. Why not use reflections or other ways to generate this 
map automatically (essentially iterate all ResourceObjectType and set the 
"lowercaseclassname" to the Class) @ravening ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to