SadiJr opened a new pull request, #5902: URL: https://github.com/apache/cloudstack/pull/5902
### Description The default behavior of ACS is to try to use all available public IPs, including those reserved for system VMs; by default when a public IP is reserved to System VM, they are used as preferred to be allocated to system VMs, but not restricted to these type of VMs. This behavior can be changed by changing the value of the global setting `system.vm.public.ip.reservation.mode.strictness` from false to true. However, if an IP reserved for system VMs is already in use for a user VR, the parameter change will make the IP to be hidden from the user, which can lead to all sorts of confusion. Therefore, this PR is intended to address these situations. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### How Has This Been Tested? It was tested in a local lab: 1. I allocated a range of 10 IPs to System VMs with `system.vm.public.ip.reservation.mode.strictness` as false; 2. I allocated all the other IPs to another network; 3. I created a new network and started a new VM with this network; 4. Then I changed the `system.vm.public.ip.reservation.mode.strictness` to true; 5. Before the changes, in the VR details (UI), there is no IP information; 6. With this PR, the user can see correctly the IP. Also, I added new unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
