weizhouapache commented on code in PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#discussion_r854351546
##########
engine/schema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java:
##########
@@ -212,7 +212,7 @@ public NicVO findByNetworkIdAndMacAddress(long networkId,
String mac) {
SearchCriteria<NicVO> sc = AllFieldsSearch.create();
sc.setParameters("network", networkId);
sc.setParameters("macAddress", mac);
- return findOneBy(sc);
+ return findOneIncludingRemovedBy(sc);
Review Comment:
@SadiJr
can you create a new method instead of changing existing method
`findByNetworkIdAndMacAddress` ?
##########
engine/schema/src/main/java/com/cloud/vm/NicVO.java:
##########
@@ -394,4 +397,14 @@ public String getNsxLogicalSwitchPortUuid() {
public void setNsxLogicalSwitchPortUuid(String nsxLogicalSwitchPortUuid) {
this.nsxLogicalSwitchPortUuid = nsxLogicalSwitchPortUuid;
}
+
Review Comment:
@SadiJr
can you fix the issue in `[VMwareGuru.java]` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
