weizhouapache commented on code in PR #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r855967543
##########
server/src/main/java/com/cloud/api/query/vo/NetworkOfferingJoinVO.java:
##########
@@ -395,4 +398,7 @@ public void setZoneName(String zoneName) {
this.zoneName = zoneName;
}
+ public String getInternetProtocol() {
+ return internetProtocol;
Review Comment:
@shwstppr
advice: return internet protocol= "IPv4" in network offering response by
default ?
##########
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java:
##########
@@ -556,4 +570,20 @@ public boolean getEgressDefaultPolicy() {
public void setEgressDefaultPolicy(Boolean egressDefaultPolicy) {
this.egressDefaultPolicy = egressDefaultPolicy;
}
+
+ public void setInternetProtocol(String internetProtocol) {
+ this.internetProtocol = internetProtocol;
+ }
Review Comment:
@shwstppr
advice: return internet protocol= "IPv4" in network response by default and
display it on UI ?
##########
server/src/main/java/com/cloud/api/query/vo/VpcOfferingJoinVO.java:
##########
@@ -197,6 +200,10 @@ public String getZoneName() {
return zoneName;
}
+ public String getInternetProtocol() {
+ return internetProtocol;
Review Comment:
@shwstppr
advice: return internet protocol= "IPv4" in vpc offering response by
default ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
