DaanHoogland commented on code in PR #6307:
URL: https://github.com/apache/cloudstack/pull/6307#discussion_r870218542
##########
engine/components-api/src/main/java/com/cloud/storage/StorageUtil.java:
##########
@@ -33,13 +33,27 @@
import com.cloud.vm.VMInstanceVO;
import com.cloud.vm.dao.VMInstanceDao;
+import org.apache.log4j.Logger;
+
public class StorageUtil {
@Inject private ClusterDao clusterDao;
@Inject private HostDao hostDao;
@Inject private PrimaryDataStoreDao storagePoolDao;
@Inject private VMInstanceDao vmInstanceDao;
@Inject private VolumeDao volumeDao;
+ public static void traceLogStoragePools(List<StoragePool> poolList, Logger
logger, String initialMessage) {
+ if (logger.isTraceEnabled()) {
Review Comment:
extra return statement is a bad smell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
