GutoVeronezi commented on code in PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#discussion_r870639326
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java:
##########
@@ -768,7 +768,7 @@ private void syncVMVolumes(VMInstanceVO vmInstanceVO,
List<VirtualDisk> virtualD
volume = createVolume(disk, vmToImport, domainId, zoneId,
accountId, instanceId, poolId, templateId, backup, true);
operation = "created";
}
- s_logger.debug(String.format("VM [id: %s, instanceName: %s] backup
restore operation %s volume [id: %s].", instanceId,
vmInstanceVO.getInstanceName(),
+ s_logger.debug(String.format("Sync volumes to VM [id: %s,
instanceName: %s] in backup restore operation: %s volume [id: %s].",
instanceId, vmInstanceVO.getInstanceName(),
Review Comment:
Actually, @SadiJr `VMInstanceVO` has the `toString()` implemented;
therefore, you can pass the only the VM object:
```suggestion
s_logger.debug(String.format("Sync volumes to %s in backup
restore operation: %s volume [id: %s].", vmInstanceVO,
```
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java:
##########
@@ -768,7 +768,7 @@ private void syncVMVolumes(VMInstanceVO vmInstanceVO,
List<VirtualDisk> virtualD
volume = createVolume(disk, vmToImport, domainId, zoneId,
accountId, instanceId, poolId, templateId, backup, true);
operation = "created";
}
- s_logger.debug(String.format("VM [id: %s, instanceName: %s] backup
restore operation %s volume [id: %s].", instanceId,
vmInstanceVO.getInstanceName(),
+ s_logger.debug(String.format("Sync volumes to VM [id: %s,
instanceName: %s] in backup restore operation: %s volume [id: %s].",
instanceId, vmInstanceVO.getInstanceName(),
Review Comment:
Actually, @SadiJr, `VMInstanceVO` has the `toString()` implemented;
therefore, you can pass the only the VM object:
```suggestion
s_logger.debug(String.format("Sync volumes to %s in backup
restore operation: %s volume [id: %s].", vmInstanceVO,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
