DaanHoogland commented on code in PR #6307:
URL: https://github.com/apache/cloudstack/pull/6307#discussion_r871112941


##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -2497,7 +2573,7 @@ public Volume detachVolumeFromVM(DetachVolumeCmd cmmd) {
             AsyncJob job = asyncExecutionContext.getJob();
 
             if (s_logger.isInfoEnabled()) {
-                s_logger.info("Trying to attaching volume " + volumeId + "to 
vm instance:" + vm.getId() + ", update async job-" + job.getId() + " progress 
status");
+                s_logger.info(String.format("Trying to attach volume [%s/%s] 
to VM instance [%s/%s], update async job-%s progress status", volume.getName(), 
volume.getUuid(), vm.getName(), vm.getUuid(), job.getId()));

Review Comment:
   changed it, please have a look if this is what you mean, @GutoVeronezi ?
   it seems a bit over the top to me, if I may say so myself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to