rohityadavcloud commented on code in PR #6398:
URL: https://github.com/apache/cloudstack/pull/6398#discussion_r876624681
##########
.github/workflows/coverage-check.yml:
##########
@@ -33,8 +33,6 @@ jobs:
id: ui-changes
uses: tj-actions/changed-files@a59f800cbb60ed483623848e31be67659a2940f8
with:
- sha: "${{ github.pull_request.sha }}"
- base_sha: "${{ github.sha }}"
Review Comment:
Due to the way `pull_request_target` works, when explicit sha, base_sha
aren't passed I saw it fails to diff well. Maybe the values aren't right,
something else should be passed? (for ex. base_sha of the main or target
branch?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
