weizhouapache commented on code in PR #6413:
URL: https://github.com/apache/cloudstack/pull/6413#discussion_r883682696
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -1557,8 +1557,9 @@ public boolean getExecuteInSequence(final HypervisorType
hypervisorType) {
case LXC:
return false;
case VMware:
- final Boolean fullClone =
HypervisorGuru.VmwareFullClone.value();
- return fullClone;
+ final Boolean fullClone = getFullCloneConfiguration();
+ final Boolean allowParallel =
getAllowParallelExecutionConfiguration();
+ return fullClone && !allowParallel;
Review Comment:
@DaanHoogland @nvazquez @sureshanaparti @andrijapanicsb
I have discussed with Daan about this part of code.
It looks in 4.17, the global configuration `VmwareFullClone` impacts not
only `CopyCommand`, but all other vm commands like `StartCommand`,
`StopCommand`, `MigrateCommand`, `RebootCommand`.
This seems to be wrong, in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
