rohityadavcloud commented on code in PR #6451:
URL: https://github.com/apache/cloudstack/pull/6451#discussion_r895595359
##########
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java:
##########
@@ -150,6 +150,9 @@ public static String buildAuthnRequestUrl(final String
authnId, final SAMLProvid
if (spMetadata.getKeyPair() != null) {
privateKey = spMetadata.getKeyPair().getPrivate();
}
+ if
(idpMetadata.getEntityId().startsWith("https://accounts.google.com/o/saml2?idpid=";))
{
Review Comment:
Can we use URIBuilder instead,
https://hc.apache.org/httpcomponents-core-5.1.x/5.1.1/httpcore5/apidocs/org/apache/hc/core5/net/URIBuilder.html
... or similar that helps generate the url based on a base URL and query
params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
