wido commented on issue #6424: URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-1155263243
> Hate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc. > > With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths? Thoughts @weizhouapache @wido @rohityadavcloud ? No, I actually think we should implement this in the Java bindings where possible, but ofcourse, caution is needed. The reason things were implemented in shell scripts is because people didn't bother in implementing it in libvirt-java and thus just took the easier route. Using the API calls of Libvirt is safer, has better Exception handling and such. Where possible, use that :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
