GutoVeronezi commented on PR #6430: URL: https://github.com/apache/cloudstack/pull/6430#issuecomment-1161758141
> code looks good @GutoVeronezi , but did you check if the list is retrieved in other places as well? I agree it should work like this and if removed nics should be retrieved as well a method like `listNicsIncludingRomoved()`. This is not always implemented this way so care must be taken. Hi @DaanHoogland, `nicSearch` is declared in the method scope and is only used by `AccountDataCenterVirtualSearch`, which is only used by the method `listVirtualNetworkInstancesByAcctAndNetwork`, which is only called in the API `listLoadBalancerRuleInstances` workflow:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
