RodrigoDLopez opened a new pull request, #6508:
URL: https://github.com/apache/cloudstack/pull/6508

   ### Description
   When detaching a volume, if the volume is in use inside the VM, the 
hypervisor waits until it is possible to execute the task. This waiting period 
causes ACS to interpret that the disk could not be removed and presents an 
error message to the user. This behavior can generate inconsistencies, because 
the volume detach is performed, but the ACS does not identify this information. 
If the user requests the volume detach again, a new error message is presented, 
saying that the volume in question is not contained in the target instance.
   
   To work around the situation, the `wait.detach.device` property was created 
in the `agent.properties` file. It determines, in milliseconds, the time ACS 
will wait before considering the detach command to have failed. The default 
value of this property is 10000 (10 seconds).
   
   Also, changes have been made so that an exception is not thrown when the 
user tries to remove a volume that is no longer contained in the VM. That way, 
if the detach command fails to extrapolate the time configured by the 
wait.detach.device property, but the volume is still removed from the instance 
by the hypervisor, the user can later remove it via the UI, without having to 
stop the VM to perform this procedure.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   
   ### How Has This Been Tested?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to