GabrielBrascher commented on code in PR #6509:
URL: https://github.com/apache/cloudstack/pull/6509#discussion_r907591782
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/MigrateKVMAsync.java:
##########
@@ -121,6 +130,25 @@ public Domain call() throws LibvirtException {
flags |= VIR_MIGRATE_AUTO_CONVERGE;
}
- return dm.migrate(dconn, flags, dxml, vmName, "tcp:" + destIp,
libvirtComputingResource.getMigrateSpeed());
+ if (StringUtils.isNotBlank(rootDiskDiskDeviceLabel) && migrateStorage
&& !migrateNonSharedInc) {
+ return migrateRootDisk(flags, rootDiskDiskDeviceLabel, destUri);
+ }
+ return dm.migrate(dconn, flags, dxml, vmName, destUri,
libvirtComputingResource.getMigrateSpeed());
+ }
+
+ /**
+ * Uses libvirt.virDomainMigrate3 in order to map the root volume to be
copied when using the flag VIR_MIGRATE_NON_SHARED_DISK.
+ * VIR_MIGRATE_NON_SHARED_DISK is analagous to "--copy-all" in "virsh".
+ * This command would be "translated" into:
Review Comment:
Now I see an issue in this documentation, I did not finish the example which
I was going to parse.
`virsh migrate i-2-13456-VM qemu://<Dest IP address>/system --live
--compressed --copy-storage-all --migrate-disks vda --xml i-2-13456-VM.xml`
Either I remove `This command would be "translated" into:`, or add the
example.
Also, typo in `analagous`, instead of `analogous`
I will do changes only after the `@blueorangutan package` tests are
finished first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
