[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

Tue, 05 Jul 2022 01:39:58 -0700 


DaanHoogland commented on PR #6348:
URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1174783149

   > SonarCloud Quality Gate failed.    [![Quality Gate 
failed](https://camo.githubusercontent.com/121da9aaaee76c9a59af5d57beb6400e9b2974722e1f71a33c0b4dc445b55041/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f6661696c65642e737667)](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6348)
   > 
   > 
[![Bug](https://camo.githubusercontent.com/575c33053884b5ef49671786eee7be86afa65d53d1154a8109acf87f7970e71d/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6275672e737667)](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=BUG)
 
[![A](https://camo.githubusercontent.com/36a358eb301bdb2c21a371c14a76fe760cc9fa629c65d6c8f2a5e0a022019286/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f526174696e6742616467652f412e737667)](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=BUG)
 
[![Vulnerability](https://camo.githubusercontent.com/5d2e7c4abe6651f9de1cfa749a41019b00550ca1fe7f339d25706c542d63
 
71e3/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f76756c6e65726162696c6974792e737667)](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=VULNERABILITY)
 
[![A](https://camo.githubusercontent.com/36a358eb301bdb2c21a371c14a76fe760cc9fa629c65d6c8f2a5e0a022019286/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f526174696e6742616467652f412e737667)](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=VULNERABILITY)
 [![Security 
Hotspot](https://camo.githubusercontent.com/df4c9bd73bfbbf055a8768ddc07836a345c6d52a36594d1a57b67d03b03d2430/68747470733a2f2f736f6e6172736f75726365
 
2e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f73656375726974795f686f7473706f742e737667)](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6348&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://camo.githubusercontent.com/36a358eb301bdb2c21a371c14a76fe760cc9fa629c65d6c8f2a5e0a022019286/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f526174696e6742616467652f412e737667)](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6348&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6348&resolved=false&types=SECURITY_HOTSPOT)
 [![Code 
Smell](https://camo.githubusercontent.com/3aa5d5d2ca02856fc823191235ea45389dd267369193d110fa2dd216ad7dc214/68747470733a2f2f736f6e6172736f7572636
 
52e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f636f64655f736d656c6c2e737667)](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=CODE_SMELL)
 
[![A](https://camo.githubusercontent.com/36a358eb301bdb2c21a371c14a76fe760cc9fa629c65d6c8f2a5e0a022019286/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f526174696e6742616467652f412e737667)](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=CODE_SMELL)
 [16 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6348&resolved=false&types=CODE_SMELL)
   > 
   > 
[![20.4%](https://camo.githubusercontent.com/7ec981eaeceb73149fb160a95c9a71d4776164c79c22226e15c68bc74facd91f/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f436f76657261676543686172742f302e737667)](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6348&metric=new_coverage&view=list)
 [20.4% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6348&metric=new_coverage&view=list)
 
[![0.0%](https://camo.githubusercontent.com/79462a906ea67fccf40f754ae817836e77820693abc6a4576361a3c9f48f3468/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f4475706c69636174696f6e732f332e737667)](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6348&metric=new_duplicated_lines_density&view=list)
 [0.0% Duplication](https://sona
 
rcloud.io/component_measures?id=apache_cloudstack&pullRequest=6348&metric=new_duplicated_lines_density&view=list)
   
   @paulazomig can you go through these ^? most make sense and though some are 
from before your days in the project they might be little effort for a small 
improvement making the code more robust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to