jbampton commented on PR #6528: URL: https://github.com/apache/cloudstack/pull/6528#issuecomment-1177295979
The flake8 lint fix was here #6529 which added a single line at the end of a Python file. So the Super Linter was taking over 10 minutes to run. So in #6531 we changed the linter to just check the files in each pull request and it now takes about 2 minutes to run. Seems having a blank line at the end of a file is best practice. Flake8 is now linting for 3 rules all whitespace related shown here https://github.com/apache/cloudstack/blob/0cae4406fb6f5af1d00e3c8ed21d3e77461fe44b/.github/linters/.flake8#L19 Python has PEP 8 – Style Guide for Python Code and whilst you don't have to follow it, it does talk about some best practices. https://peps.python.org/pep-0008/ So this work with the Super-Linter is all about code standards. I think using `pre-commit` is just the next extension to getting all the linters/checks running on your local machine. I would be happy to write up some docs if needed on all this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
