joseflauzino commented on PR #6358: URL: https://github.com/apache/cloudstack/pull/6358#issuecomment-1212112323
Thanks for the review, @weizhouapache and @GabrielBrascher. I have just committed the new version of the code. These are the relevant changes: 1. Now the stats parameter of the memballoon tag will be set to 0 when `vm.memballoon.disable=true`. 2. Virsh commands have been replaced by methods from the Domain class. The only exception is the command to set the stats parameter of the memballoon tag (`virsh dommemstat <vm-name-or-id> --period <value-in-seconds> --live`), which cannot be replaced by the `memoryStats(int number)` method. The reason is that this method only allows us to get the memory stats and not to set the new gathering period in the VM XML (as desired). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
