mlsorensen commented on code in PR #6640:
URL: https://github.com/apache/cloudstack/pull/6640#discussion_r947009958
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1421,13 +1438,18 @@ public String getContent() {
netBuilder.append(_dpdkExtraLines);
}
- if (_netType != GuestNetType.VHOSTUSER) {
+ if (_netType != GuestNetType.VHOSTUSER && _netType !=
GuestNetType.USER) {
netBuilder.append("<link state='" + (_linkStateUp ? "up" :
"down") +"'/>\n");
}
if (_slot != null) {
netBuilder.append(String.format("<address type='pci'
domain='0x0000' bus='0x00' slot='0x%02x' function='0x0'/>\n", _slot));
}
+
+ if (StringUtils.isNotBlank(_userIp4Network) && _userIp4Prefix !=
null) {
+ netBuilder.append(String.format("<ip family='ipv4'
address='%s' prefix='%s'/>\n", _userIp4Network, _userIp4Prefix));
Review Comment:
I'd probably opt to leave it as-is, rather than potentially inserting one
random carriage return or something different on one line of the file compared
to all of the other lines.
I don't think a theoretical libvirt server would care/require a carriage or
alternate whitespace on Windows or other OS anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
