fermosan commented on PR #6550: URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1228299646
Hello, replies inline. > Did a round of review, in addition to the requested changes or questions, pl also: > > * rebase your branch against last main branch to allow sonar and other checks to re-kick done. > * look at any code smells reported by the sonarcloud bot and see coverage report by codecov if it helps to improve the code will do > * add any marvin/functional test There are some tests already implemented. > > Misc: > > * Does this plugin ship as enabled by default, is there a way to disable it? It is enabled by selecting Networker as B&R Plugin from general options. > * Does it require any UI or DB/schema changes etc? No UI or DB/schema changes required. For more details you can check: https://github.com/apache/cloudstack-documentation/pull/281 Since it's vacation period for us we will revert with the changes your requested when we get back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
